Bug 175768

Summary: media-captions.html improvements
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: Tools / TestsAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-21 07:01:52 PDT 
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-21 07:04:32 PDT 
Created attachment 318630 [details]
Patch
Comment 2 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-21 07:04:46 PDT 
For the record, the failure on GTK is

--- media-captions-expected.txt
+++ media-captions-actual.txt
@@ -18,10 +18,10 @@
 EVENT(loadstart)
 EVENT(durationchange)
 EVENT(canplaythrough)
-EXPECTED (mediaElement.webkitHasClosedCaptions == 'true') OK
+EXPECTED (mediaElement.webkitHasClosedCaptions == 'true'), OBSERVED 'false' FAIL
 EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'false') OK
 *** enabling captions
-EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true') OK
+EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true'), OBSERVED 'false' FAIL
 
 END OF TEST
Comment 3 WebKit Commit Bot 2017-08-21 08:44:31 PDT 
Comment on attachment 318630 [details]
Patch

Clearing flags on attachment: 318630

Committed r220965: <http://trac.webkit.org/changeset/220965>
Comment 4 WebKit Commit Bot 2017-08-21 08:44:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-21 08:45:37 PDT 
<rdar://problem/33992226>