Bug 175761

Summary: [EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, buildbot, calvaris, jer.noble, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Zan Dobersek 2017-08-20 23:58:04 PDT 
[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'
Comment 1 Zan Dobersek 2017-08-21 00:42:26 PDT 
Created attachment 318617 [details]
Patch
Comment 2 Build Bot 2017-08-21 00:45:26 PDT 
Attachment 318617 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:140:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xabier Rodríguez Calvar 2017-08-21 03:07:29 PDT 
Comment on attachment 318617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318617&action=review

> Source/WebCore/ChangeLog:15
> +        the platform layer. The gist of the algorithm is to invoke the decryption

gist?

> Source/WebCore/ChangeLog:17
> +        retrieved from the MediaKeys object that's associated with this media

I've never seen that's contracted when that is the subordinate pronoun, but I might be wrong...

> Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:140
> +        [](auto& session) { return !session->isClosed(); });

Fix the style checker complain. And it looks like you should leave a space between the [] and the (
Comment 4 Zan Dobersek 2017-08-21 05:29:39 PDT 
Created attachment 318628 [details]
Patch for landing
Comment 5 Zan Dobersek 2017-08-21 05:56:46 PDT 
Comment on attachment 318628 [details]
Patch for landing

Clearing flags on attachment: 318628

Committed r220962: <http://trac.webkit.org/changeset/220962>
Comment 6 Zan Dobersek 2017-08-21 05:56:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-21 05:57:55 PDT 
<rdar://problem/33990737>
Comment 8 Michael Catanzaro 2017-08-21 15:34:07 PDT 
(In reply to Xabier Rodríguez Calvar from comment #3)
> > Source/WebCore/ChangeLog:15
> > +        the platform layer. The gist of the algorithm is to invoke the decryption
> 
> gist?

It means "the general idea" (of the algorithm).

> I've never seen that's contracted when that is the subordinate pronoun, but
> I might be wrong...

It's fine!