Bug 175751

Summary:

Forbid setDragImage after dragstart

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

UI Events

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, megan_gardner, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Removes the code	none

Description Ryosuke Niwa 2017-08-18 20:42:20 PDT

Right now, WebKit allows setting the drag image after dragstart had happened.

However, this doesn't work in WebKit2, and it's pretty much broken in WebKit1,
and doesn't match the spec or the behaviors of Chrome and Firefox.

Remove this broken feature.

Comment 1 Ryosuke Niwa 2017-08-18 21:35:50 PDT

Created attachment 318581 [details]
Removes the code

Comment 2 Wenson Hsieh 2017-08-18 22:55:05 PDT

Comment on attachment 318581 [details]
Removes the code

r=me. A bit sad this was never tested at all :(

Comment 3 WebKit Commit Bot 2017-08-18 23:40:33 PDT

Comment on attachment 318581 [details]
Removes the code

Clearing flags on attachment: 318581

Committed r220951: <http://trac.webkit.org/changeset/220951>

Comment 4 WebKit Commit Bot 2017-08-18 23:40:35 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2017-08-18 23:41:09 PDT

<rdar://problem/33977048>