Bug 175745

Summary: Split the one SWServer::Connection into SWClientConnection and SWServer::Connection
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: ASSIGNED ---    
Severity: Normal CC: achristensen, aestes, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=175795
Attachments:
Description Flags
EWS
none
EWS
none
EWS
none
EWS
none
Patch
aestes: review+
PFL
none
PFL none

Description Brady Eidson 2017-08-18 16:43:25 PDT
Split the one SWServer::Connection into SWClientConnection and SWServer::Connection

Each has much different environments they need to live in.
Comment 1 Brady Eidson 2017-08-18 16:54:45 PDT Comment hidden (obsolete)
Comment 2 Brady Eidson 2017-08-18 17:10:04 PDT Comment hidden (obsolete)
Comment 3 Brady Eidson 2017-08-18 19:19:59 PDT Comment hidden (obsolete)
Comment 4 Brady Eidson 2017-08-18 20:10:43 PDT Comment hidden (obsolete)
Comment 5 Brady Eidson 2017-08-18 22:14:12 PDT
Created attachment 318582 [details]
Patch
Comment 6 Andy Estes 2017-08-21 10:37:17 PDT
Comment on attachment 318582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318582&action=review

I find it a little strange that these "Connection" classes are both MessageSenders and MessageReceivers. It seems like we usually split these into separate classes and don't use the word "ConnectIon" in the receivers. Just something to think about.

> Source/WebCore/workers/service/server/SWClientConnection.cpp:36
> +#include <wtf/HashMap.h>
> +#include <wtf/HashSet.h>
> +#include <wtf/ThreadSafeRefCounted.h>

Two out of three of these are included in SWClientConnection.h

> Source/WebCore/workers/service/server/SWServer.cpp:65
> +    connection.rejectJobInClient(jobData.identifier, ExceptionData { UnknownError, ASCIILiteral("serviceWorker job scheduling is not yet implemented") });

NotSupportedError seems more appropriate. Doesn't really matter since it's temporary code.
Comment 7 Brady Eidson 2017-08-21 11:34:08 PDT
Created attachment 318649 [details]
PFL
Comment 8 Brady Eidson 2017-08-21 11:47:33 PDT
Created attachment 318654 [details]
PFL
Comment 9 WebKit Commit Bot 2017-08-21 13:02:47 PDT
Comment on attachment 318654 [details]
PFL

Clearing flags on attachment: 318654

Committed r220977: <http://trac.webkit.org/changeset/220977>