Summary: | Fix leak-checking for iOS Simulators | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, buildbot, commit-queue, darin, dbates, ddkilzer, glenn, lforschler, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2017-08-18 13:45:23 PDT
Created attachment 318537 [details]
Patch
Comment on attachment 318537 [details] Patch Clearing flags on attachment: 318537 Committed r220942: <http://trac.webkit.org/changeset/220942> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 318700 [details]
Patch
Created attachment 318709 [details]
Patch
Comment on attachment 318709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318709&action=review r=me > Tools/Scripts/webkitpy/port/server_process.py:377 > # read any remaining data on the pipes and return it. > if not killed: > - if self._use_win32_apis: > + if self._use_win32_apis and self._proc: > self._wait_for_data_and_update_buffers_using_win32_apis(now) > - else: > + elif self._proc: > self._wait_for_data_and_update_buffers_using_select(now, stopping=True) Can you move the check for self._proc here? if not killed and self._proc: (In reply to David Kilzer (:ddkilzer) from comment #8) > Comment on attachment 318709 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318709&action=review > > r=me > > > Tools/Scripts/webkitpy/port/server_process.py:377 > > # read any remaining data on the pipes and return it. > > if not killed: > > - if self._use_win32_apis: > > + if self._use_win32_apis and self._proc: > > self._wait_for_data_and_update_buffers_using_win32_apis(now) > > - else: > > + elif self._proc: > > self._wait_for_data_and_update_buffers_using_select(now, stopping=True) > > Can you move the check for self._proc here? > > if not killed and self._proc: Good point. Making that change. Created attachment 318757 [details]
Patch for landing
Comment on attachment 318757 [details] Patch for landing Clearing flags on attachment: 318757 Committed r221011: <http://trac.webkit.org/changeset/221011> All reviewed patches have been landed. Closing bug. |