Summary: | [Curl] Improve multi-threaded networking | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daewoong Jang <daewoong.jang> | ||||||
Component: | WebCore Misc. | Assignee: | Daewoong Jang <daewoong.jang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, darin, don.olmstead, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Daewoong Jang
2017-08-17 22:58:38 PDT
Created attachment 318477 [details]
patch part 2
Comment on attachment 318477 [details] patch part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=318477&action=review > Source/WebCore/platform/network/curl/CurlDownload.cpp:62 > - m_url = url; > + m_url = url.isolatedCopy(); I don't think this is necessary. This is not the point at which we are moving to another thread. > Source/WebCore/platform/network/curl/CurlJobManager.cpp:86 > + default: > + ASSERT_NOT_REACHED(); This should be removed. Created attachment 318542 [details]
patch part 2
(In reply to Alex Christensen from comment #2) > Comment on attachment 318477 [details] > patch part 2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318477&action=review > > > Source/WebCore/platform/network/curl/CurlDownload.cpp:62 > > - m_url = url; > > + m_url = url.isolatedCopy(); > > I don't think this is necessary. This is not the point at which we are > moving to another thread. > > > Source/WebCore/platform/network/curl/CurlJobManager.cpp:86 > > + default: > > + ASSERT_NOT_REACHED(); > > This should be removed. I have updated my patch. Thanks for review! Comment on attachment 318542 [details] patch part 2 Clearing flags on attachment: 318542 Committed r220939: <http://trac.webkit.org/changeset/220939> All reviewed patches have been landed. Closing bug. |