Bug 175675

Summary: -Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebCore Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Trivial CC: buildbot, commit-queue, jiewen_tan, mcatanzaro, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2017-08-17 09:23:11 PDT 
Some new warnings:

[2743/5943] Building CXX object Source...les/WebCore.dir/crypto/CryptoKey.cpp.o
../../Source/WebCore/crypto/CryptoKey.cpp: In member function ‘WebCore::CryptoKey::AlgorithmVariant WebCore::CryptoKey::algorithm() const’:
../../Source/WebCore/crypto/CryptoKey.cpp:70:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
[2780/5943] Building CXX object Source.../WebCore.dir/crypto/SubtleCrypto.cpp.o
../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘WebCore::CryptoKeyUsageBitmap WebCore::toCryptoKeyUsageBitmap(WebCore::CryptoKeyUsage)’:
../../Source/WebCore/crypto/SubtleCrypto.cpp:397:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘std::optional<WTF::Variant<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16>, WebCore::JsonWebKey> > WebCore::toKeyData(WebCore::SubtleCrypto::KeyFormat, WebCore::SubtleCrypto::KeyDataVariant&&, WTF::Ref<WebCore::DeferredPromise>&)’:
../../Source/WebCore/crypto/SubtleCrypto.cpp:479:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
Comment 1 Michael Catanzaro 2017-08-17 09:26:13 PDT 
Created attachment 318374 [details]
Patch
Comment 2 Jiewen Tan 2017-08-17 11:48:42 PDT 
Comment on attachment 318374 [details]
Patch

Looks good to me. r=me. Nice!
Comment 3 WebKit Commit Bot 2017-08-17 14:17:38 PDT 
Comment on attachment 318374 [details]
Patch

Clearing flags on attachment: 318374

Committed r220876: <http://trac.webkit.org/changeset/220876>
Comment 4 WebKit Commit Bot 2017-08-17 14:17:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-17 14:18:59 PDT 
<rdar://problem/33949830>