Summary: | [GStreamer] GstStructure shouldn't be handled through GRefPtr | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2017-08-17 07:57:41 PDT
Created attachment 318368 [details]
Patch
Comment on attachment 318368 [details]
Patch
O_O
This is bad. How did it not crash? How did it even compile if it doesn't support g_object_ref/unref and there's no template specialization for GstStructure? Comment on attachment 318368 [details] Patch Clearing flags on attachment: 318368 Committed r220861: <http://trac.webkit.org/changeset/220861> All reviewed patches have been landed. Closing bug. (In reply to Michael Catanzaro from comment #3) > This is bad. How did it not crash? How did it even compile if it doesn't > support g_object_ref/unref and there's no template specialization for > GstStructure? I ask myself the same question. (In reply to Xabier Rodríguez Calvar from comment #6) > (In reply to Michael Catanzaro from comment #3) > > This is bad. How did it not crash? How did it even compile if it doesn't > > support g_object_ref/unref and there's no template specialization for > > GstStructure? > > I ask myself the same question. gst_object_ref() was never called because all values were adopted into the GRefPtr<> object. gst_object_unref() was never called because the managed pointer was leaked from the GRefPtr<> object. |