Bug 175671

Summary:

[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2017-08-17 07:16:08 PDT

[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement

Comment 1 Zan Dobersek 2017-08-17 07:26:55 PDT

Created attachment 318365 [details]
Patch

Comment 2 Zan Dobersek 2017-08-18 00:45:52 PDT

Comment on attachment 318365 [details]
Patch

Clearing flags on attachment: 318365

Committed r220905: <http://trac.webkit.org/changeset/220905>

Comment 3 Zan Dobersek 2017-08-18 00:45:56 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2017-08-18 00:47:26 PDT

<rdar://problem/33958693>

Comment 5 Darin Adler 2017-08-18 09:24:20 PDT

Comment on attachment 318365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318365&action=review

> Source/WebCore/html/HTMLMediaElement.h:640
> +    void cdmClientAttemptToResumePlaybackIfNecessary() override;

Slightly better to write "final" here rather than override. Not important at all in this patch, just a general style thing. We should start things both "as private as possible" and "as final as possible" and make them less private and less final as needed.