Bug 175668

Summary: [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174858    
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2017-08-17 05:03:01 PDT
[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline
Attachments
Patch (5.36 KB, patch)
2017-08-17 05:10 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (5.42 KB, patch)
2017-08-17 07:41 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-08-17 05:10:48 PDT
Created attachment 318353 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-08-17 06:11:40 PDT
Comment on attachment 318353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review > Source/WebCore/ChangeLog:3 > + [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline intothe > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95 > -private: Oops? > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 > + GstStructure* m_pendingDecryptionStructure { nullptr }; Let's make this a GRefPtr.
Zan Dobersek
Comment 3 2017-08-17 06:23:19 PDT
Comment on attachment 318353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95 >> -private: > > Oops? No, it removes a duplicated label that you can see above. >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 >> + GstStructure* m_pendingDecryptionStructure { nullptr }; > > Let's make this a GRefPtr. GstStructure isn't ref-counted.
Xabier Rodríguez Calvar
Comment 4 2017-08-17 06:29:30 PDT
(In reply to Zan Dobersek from comment #3) > > Oops? > > No, it removes a duplicated label that you can see above. Good then. > >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 > >> + GstStructure* m_pendingDecryptionStructure { nullptr }; > > > > Let's make this a GRefPtr. > > GstStructure isn't ref-counted. You're right. You need to use GUniquePtr instead.
Zan Dobersek
Comment 5 2017-08-17 07:41:38 PDT
Created attachment 318367 [details] Patch
Zan Dobersek
Comment 6 2017-08-17 09:40:59 PDT
Comment on attachment 318367 [details] Patch Clearing flags on attachment: 318367 Committed r220862: <http://trac.webkit.org/changeset/220862>
Zan Dobersek
Comment 7 2017-08-17 09:41:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-17 09:42:05 PDT
<rdar://problem/33942309>
Note You need to log in before you can comment on or make changes to this bug.