Summary: | [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 174858 | ||||||||
Attachments: |
|
Description
Zan Dobersek
2017-08-17 05:03:01 PDT
Created attachment 318353 [details]
Patch
Comment on attachment 318353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review > Source/WebCore/ChangeLog:3 > + [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline intothe > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95 > -private: Oops? > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 > + GstStructure* m_pendingDecryptionStructure { nullptr }; Let's make this a GRefPtr. Comment on attachment 318353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95 >> -private: > > Oops? No, it removes a duplicated label that you can see above. >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 >> + GstStructure* m_pendingDecryptionStructure { nullptr }; > > Let's make this a GRefPtr. GstStructure isn't ref-counted. (In reply to Zan Dobersek from comment #3) > > Oops? > > No, it removes a duplicated label that you can see above. Good then. > >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155 > >> + GstStructure* m_pendingDecryptionStructure { nullptr }; > > > > Let's make this a GRefPtr. > > GstStructure isn't ref-counted. You're right. You need to use GUniquePtr instead. Created attachment 318367 [details]
Patch
Comment on attachment 318367 [details] Patch Clearing flags on attachment: 318367 Committed r220862: <http://trac.webkit.org/changeset/220862> All reviewed patches have been landed. Closing bug. |