| Summary: | [PAL] Move spi/mac directory into PAL | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, buildbot, commit-queue, don.olmstead, mmaxfield, webkit-bug-importer, yoshiaki.jitsukawa | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yoshiaki Jitsukawa
2017-08-16 17:04:28 PDT
Created attachment 318312 [details]
Patch
- Move WebCore/platform/spi/mac to WebCore/PAL/pal/spi/mac
- Fix Xcode projects for it
- Fix include paths
- Fix relevant coding style errors
- Make the style checker ignore false positive "whitespace/operators" error for __has_include()
Attachment 318312 [details] did not pass style-queue:
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 84 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318313 [details]
Patch
Hmm, the style checker on my env doesn't complain about the [build/include_order]
error, but I try restoring the blank line.
Attachment 318313 [details] did not pass style-queue:
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 84 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318459 [details]
Patch
Comment on attachment 318459 [details] Patch Clearing flags on attachment: 318459 Committed r220979: <http://trac.webkit.org/changeset/220979> All reviewed patches have been landed. Closing bug. Thank you for your reviewing, Myles ;) |