Bug 175627

Summary: Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, kling, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2017-08-16 04:48:28 PDT
Render tree should not mutate itself. We already fixed this for first-letter and the code can now move to RenderTreeUpdater.
Attachments
patch (45.22 KB, patch)
2017-08-16 04:54 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-08-16 04:54:09 PDT
Created attachment 318254 [details] patch
Andreas Kling
Comment 2 2017-08-16 05:19:25 PDT
Comment on attachment 318254 [details] patch r=me without the bogus Xcode project changes
Antti Koivisto
Comment 3 2017-08-16 05:36:53 PDT
The project file changes appear to be correct, XCode is cleaning up some duplicates.
WebKit Commit Bot
Comment 4 2017-08-16 06:15:24 PDT
Comment on attachment 318254 [details] patch Clearing flags on attachment: 318254 Committed r220795: <http://trac.webkit.org/changeset/220795>
WebKit Commit Bot
Comment 5 2017-08-16 06:15:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-16 06:16:05 PDT
<rdar://problem/33917420>
Note You need to log in before you can comment on or make changes to this bug.