Bug 175627 - Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
Summary: Move first-letter renderer mutation code out of RenderBlock and into RenderTr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-16 04:48 PDT by Antti Koivisto
Modified: 2017-08-16 06:16 PDT (History)
6 users (show)

See Also:


Attachments
patch (45.22 KB, patch)
2017-08-16 04:54 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-08-16 04:48:28 PDT
Render tree should not mutate itself. We already fixed this for first-letter and the code can now move to RenderTreeUpdater.
Comment 1 Antti Koivisto 2017-08-16 04:54:09 PDT
Created attachment 318254 [details]
patch
Comment 2 Andreas Kling 2017-08-16 05:19:25 PDT
Comment on attachment 318254 [details]
patch

r=me without the bogus Xcode project changes
Comment 3 Antti Koivisto 2017-08-16 05:36:53 PDT
The project file changes appear to be correct, XCode is cleaning up some duplicates.
Comment 4 WebKit Commit Bot 2017-08-16 06:15:24 PDT
Comment on attachment 318254 [details]
patch

Clearing flags on attachment: 318254

Committed r220795: <http://trac.webkit.org/changeset/220795>
Comment 5 WebKit Commit Bot 2017-08-16 06:15:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-16 06:16:05 PDT
<rdar://problem/33917420>