Summary: | [WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, jiewen_tan, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Zan Dobersek
2017-08-15 21:57:15 PDT
Created attachment 318229 [details]
WIP patch
Attachment 318229 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318259 [details]
WIP patch
Attachment 318259 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318482 [details]
Patch
Ready for review.
Created attachment 318625 [details]
Patch
Created attachment 319070 [details]
Patch
Comment on attachment 319070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319070&action=review Looks good to me. r=me. Good job. > Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp:102 > + return signature.size() == expectedSignature.size() && !constantTimeMemcmp(expectedSignature.data(), signature.data(), expectedSignature.size()); Forget to copy a comment here. Created attachment 319248 [details]
Patch for landing
Comment on attachment 319248 [details] Patch for landing Clearing flags on attachment: 319248 Committed r221294: <http://trac.webkit.org/changeset/221294> All reviewed patches have been landed. Closing bug. |