Bug 175615

Summary: Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, enrica, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Megan Gardner
Reported 2017-08-15 20:26:18 PDT
Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Attachments
Patch (7.60 KB, patch)
2017-08-15 20:35 PDT, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2017-08-15 20:35:46 PDT
Created attachment 318219 [details] Patch
Tim Horton
Comment 2 2017-08-16 16:06:44 PDT
Comment on attachment 318219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318219&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2551 > + selectionChangedWithGesture(self, point, gestureType, gestureState, flags | innerFlags, error); are the flags handed back from selectWithGesture UIWKSelectionFlags? why are we ORing them together? should we pass flags into selectWithGesture and then back out, instead? it's kind of unusual to smush them together like this (but maybe it makes sense?)
Megan Gardner
Comment 3 2017-08-17 18:39:38 PDT
https://trac.webkit.org/changeset/220895/webkit
Radar WebKit Bug Importer
Comment 4 2017-08-17 18:40:43 PDT
<rdar://problem/33955113>
Note You need to log in before you can comment on or make changes to this bug.