Bug 175615

Summary: Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Severity: Normal CC: bdakin, enrica, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch thorton: review+

Description Megan Gardner 2017-08-15 20:26:18 PDT
Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Comment 1 Megan Gardner 2017-08-15 20:35:46 PDT
Created attachment 318219 [details]
Comment 2 Tim Horton 2017-08-16 16:06:44 PDT
Comment on attachment 318219 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=318219&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2551
> +        selectionChangedWithGesture(self, point, gestureType, gestureState, flags | innerFlags, error);

are the flags handed back from selectWithGesture UIWKSelectionFlags? why are we ORing them together? should we pass flags into selectWithGesture and then back out, instead? it's kind of unusual to smush them together like this (but maybe it makes sense?)
Comment 3 Megan Gardner 2017-08-17 18:39:38 PDT
Comment 4 Radar WebKit Bug Importer 2017-08-17 18:40:43 PDT