| Summary: | Update to changeSelectionWithTouchAt:baseIsStart:withFlags: | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, enrica, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Megan Gardner
2017-08-15 20:26:18 PDT
Created attachment 318219 [details]
Patch
Comment on attachment 318219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318219&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2551 > + selectionChangedWithGesture(self, point, gestureType, gestureState, flags | innerFlags, error); are the flags handed back from selectWithGesture UIWKSelectionFlags? why are we ORing them together? should we pass flags into selectWithGesture and then back out, instead? it's kind of unusual to smush them together like this (but maybe it makes sense?) |