Bug 175583

Summary:

Import a better std::variant

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Web Template Framework

Assignee:

Sam Weinig <sam>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

buildbot

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Sam Weinig 2017-08-15 10:33:42 PDT

The variant implementation we currently have, https://bitbucket.org/anthonyw/variant/src, is completely standards compliant and is not being updated all that often. We should probably replace it with https://github.com/mpark/variant, which is based on the clang implementation and is  available as a single header, while we wait for all our compilers / standard libraries to support it directly.

Comment 1 Sam Weinig 2017-08-17 20:59:34 PDT Comment hidden (obsolete)

Created attachment 318464 [details]
Patch

Comment 2 Sam Weinig 2017-08-17 21:20:51 PDT Comment hidden (obsolete)

Created attachment 318467 [details]
Patch

Comment 3 Build Bot 2017-08-17 21:25:40 PDT Comment hidden (obsolete)

Comment on attachment 318467 [details]
Patch

Attachment 318467 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/4334654

New failing tests:
(JS) JSTestCallTracer.cpp

Comment 4 Sam Weinig 2017-08-18 07:11:44 PDT Comment hidden (obsolete)

Created attachment 318493 [details]
Patch

Comment 5 Sam Weinig 2017-08-18 07:13:49 PDT Comment hidden (obsolete)

Created attachment 318494 [details]
Patch

Comment 6 Sam Weinig 2017-08-18 09:25:03 PDT Comment hidden (obsolete)

Created attachment 318509 [details]
Patch

Comment 7 Sam Weinig 2017-08-19 12:26:29 PDT Comment hidden (obsolete)

Created attachment 318587 [details]
Patch

Comment 8 Sam Weinig 2017-08-19 21:59:27 PDT Comment hidden (obsolete)

Created attachment 318596 [details]
Patch

Comment 9 Sam Weinig 2017-08-19 22:22:12 PDT

Created attachment 318597 [details]
Patch