Bug 175571 – MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes

• Component: WebKit API
• Status: RESOLVED FIXED

[Charlie Turner]

After the grand move from WebKit2 -> WebKit, I was struggling to find information about these caching policies and what exactly they mean. The problem is that calculateMemoryCacheSizes fails to set cacheTotalCapacity to something sensible if the system has less than 512MB of RAM. This,

        // This code is here to avoid a PLT regression. We can remove it if we
        // can prove that the overall system gain would justify the regression.
        cacheMaxDeadCapacity = std::max(24u, cacheMaxDeadCapacity);

Then obviously violates the checks in MemoryCache::setCapacities, because at this point cacheTotalCapacity is zero from the callsite.

Patch basically follows the pattern to make sure cacheTotalCapacity is set.

[Charlie Turner]

Created attachment 318118 [details]
Patch

[Charlie Turner]

Adding Sam, because I have no idea who's best to review this patch, and you were the last one I saw doing things with this area, sorry :)

[Charlie Turner]

Please may someone cq+ this for me? I'm not a commiter.

[WebKit Commit Bot]

Comment on attachment 318118 [details]
Patch

Clearing flags on attachment: 318118

Committed r220963: <http://trac.webkit.org/changeset/220963>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33990750>