| Summary: | Enable named offsets into JSC bytecodes | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Keith Miller
2017-08-14 19:53:40 PDT
Created attachment 318104 [details]
Patch
Created attachment 318123 [details]
Patch
Comment on attachment 318123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318123&action=review r=me with fixes. Please rebase and get the EWS bots green before landing. > Source/JavaScriptCore/ChangeLog:18 > + As a first cut I converted the various instanceof bytecodes to use > + named offsets. I think it is useful to include a sample of one such generated bytecode struct here. This will give the reader a much more intuitive sense of what this patch does. > Source/JavaScriptCore/generate-bytecode-files:133 > + bytecodeHFile.write("friend class LLIntOffsetsExtractor;\n") The "friend class ..." declaration should be indented by 4 spaces i.e. need to add 4 spaces at start of string. Created attachment 318129 [details]
Patch
Created attachment 318135 [details]
Patch
Comment on attachment 318135 [details] Patch Clearing flags on attachment: 318135 Committed r220753: <http://trac.webkit.org/changeset/220753> All reviewed patches have been landed. Closing bug. |