Bug 175561

Summary: Enable named offsets into JSC bytecodes
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2017-08-14 19:53:40 PDT
Enable named offsets into JSC bytecodes
Attachments
Patch (48.96 KB, patch)
2017-08-14 20:10 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (51.78 KB, patch)
2017-08-15 09:08 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (52.97 KB, patch)
2017-08-15 10:11 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (52.98 KB, patch)
2017-08-15 10:39 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-08-14 20:10:04 PDT
Created attachment 318104 [details] Patch
Keith Miller
Comment 2 2017-08-15 09:08:54 PDT
Created attachment 318123 [details] Patch
Mark Lam
Comment 3 2017-08-15 09:40:22 PDT
Comment on attachment 318123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318123&action=review r=me with fixes. Please rebase and get the EWS bots green before landing. > Source/JavaScriptCore/ChangeLog:18 > + As a first cut I converted the various instanceof bytecodes to use > + named offsets. I think it is useful to include a sample of one such generated bytecode struct here. This will give the reader a much more intuitive sense of what this patch does. > Source/JavaScriptCore/generate-bytecode-files:133 > + bytecodeHFile.write("friend class LLIntOffsetsExtractor;\n") The "friend class ..." declaration should be indented by 4 spaces i.e. need to add 4 spaces at start of string.
Keith Miller
Comment 4 2017-08-15 10:11:02 PDT
Created attachment 318129 [details] Patch
Keith Miller
Comment 5 2017-08-15 10:39:29 PDT
Created attachment 318135 [details] Patch
WebKit Commit Bot
Comment 6 2017-08-15 13:13:58 PDT
Comment on attachment 318135 [details] Patch Clearing flags on attachment: 318135 Committed r220753: <http://trac.webkit.org/changeset/220753>
WebKit Commit Bot
Comment 7 2017-08-15 13:13:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-15 13:15:15 PDT
<rdar://problem/33902259>
Note You need to log in before you can comment on or make changes to this bug.