Bug 175556

Summary: Import eventsource Web-Platform-Tests
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, Ms2ger, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175178    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-08-14 16:37:39 PDT
Import eventsource Web-Platform-Tests.
Attachments
Patch (127.00 KB, patch)
2017-08-14 17:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (126.89 KB, patch)
2017-08-14 17:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-14 17:00:31 PDT
Created attachment 318088 [details] Patch
Chris Dumez
Comment 2 2017-08-14 17:01:58 PDT
Created attachment 318089 [details] Patch
youenn fablet
Comment 3 2017-08-14 17:13:50 PDT
Comment on attachment 318089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318089&action=review > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > +/* --> Do you know the reason for these comments here and in other tests?
Chris Dumez
Comment 4 2017-08-14 17:49:11 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 318089 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318089&action=review > > > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > > +/* --> > > Do you know the reason for these comments here and in other tests? No idea.
WebKit Commit Bot
Comment 5 2017-08-14 18:44:11 PDT
Comment on attachment 318089 [details] Patch Clearing flags on attachment: 318089 Committed r220733: <http://trac.webkit.org/changeset/220733>
WebKit Commit Bot
Comment 6 2017-08-14 18:44:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-14 18:44:41 PDT
<rdar://problem/33888819>
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 8 2017-08-15 03:29:46 PDT
(In reply to Chris Dumez from comment #4) > (In reply to youenn fablet from comment #3) > > Comment on attachment 318089 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=318089&action=review > > > > > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > > > +/* --> > > > > Do you know the reason for these comments here and in other tests? > > No idea. The way these tests work is that they load the test .htm file itself as a worker script, so they're written in a way that they can be parsed as HTML and JS both. (If they were written now, they'd use .worker.js tests.)
Michael Catanzaro
Comment 9 2017-08-15 08:04:45 PDT
Interestingly some of these tests have PASS messages for GTK where they have FAILs on macOS... I will update our expectations accordingly.
Chris Dumez
Comment 10 2017-08-15 08:25:43 PDT
(In reply to Michael Catanzaro from comment #9) > Interestingly some of these tests have PASS messages for GTK where they have > FAILs on macOS... I will update our expectations accordingly. Congratulations ;)
Note You need to log in before you can comment on or make changes to this bug.