Import eventsource Web-Platform-Tests.
Created attachment 318088 [details] Patch
Created attachment 318089 [details] Patch
Comment on attachment 318089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318089&action=review > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > +/* --> Do you know the reason for these comments here and in other tests?
(In reply to youenn fablet from comment #3) > Comment on attachment 318089 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318089&action=review > > > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > > +/* --> > > Do you know the reason for these comments here and in other tests? No idea.
Comment on attachment 318089 [details] Patch Clearing flags on attachment: 318089 Committed r220733: <http://trac.webkit.org/changeset/220733>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33888819>
(In reply to Chris Dumez from comment #4) > (In reply to youenn fablet from comment #3) > > Comment on attachment 318089 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=318089&action=review > > > > > LayoutTests/imported/w3c/web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:10 > > > +/* --> > > > > Do you know the reason for these comments here and in other tests? > > No idea. The way these tests work is that they load the test .htm file itself as a worker script, so they're written in a way that they can be parsed as HTML and JS both. (If they were written now, they'd use .worker.js tests.)
Interestingly some of these tests have PASS messages for GTK where they have FAILs on macOS... I will update our expectations accordingly.
(In reply to Michael Catanzaro from comment #9) > Interestingly some of these tests have PASS messages for GTK where they have > FAILs on macOS... I will update our expectations accordingly. Congratulations ;)