Bug 175530

Summary: Factor text autosizing into a class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, kling, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
kling: review+
patch none

Description Antti Koivisto 2017-08-14 04:47:48 PDT
It is currently in Document.
Comment 1 Antti Koivisto 2017-08-14 05:02:33 PDT
Created attachment 318032 [details]
patch
Comment 2 Antti Koivisto 2017-08-14 05:13:05 PDT
Created attachment 318033 [details]
patch
Comment 3 Andreas Kling 2017-08-14 05:14:33 PDT
Comment on attachment 318033 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318033&action=review

r=me

> Source/WebCore/rendering/TextAutoSizing.h:128
> +    using NodeMap = HashMap<TextAutoSizingKey, std::unique_ptr<TextAutoSizingValue>, TextAutoSizingHash, TextAutoSizingTraits>;
> +    NodeMap m_textNodes;

Seems like this could be accomplished in a single line, no?
Comment 4 Antti Koivisto 2017-08-14 05:38:19 PDT
Created attachment 318035 [details]
patch
Comment 5 WebKit Commit Bot 2017-08-14 06:20:51 PDT
Comment on attachment 318035 [details]
patch

Clearing flags on attachment: 318035

Committed r220685: <http://trac.webkit.org/changeset/220685>
Comment 6 WebKit Commit Bot 2017-08-14 06:20:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-14 06:22:26 PDT
<rdar://problem/33874524>