Bug 175492

Summary: Merge JSLexicalEnvironment and JSEnvironmentRecord
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: keith_miller, mark.lam, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch saam: review+

Filip Pizlo
Reported 2017-08-11 13:49:48 PDT
It looks like these are used as one type, since JSEnvironmentRecord is abstract and its only implementation is JSLexicalEnvironment.
Attachments
Patch (45.60 KB, patch)
2017-09-17 08:23 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-09-17 08:17:30 PDT
I would like to optimize toThis() operation. Before doing this, we would like to drop JSEnvironmentRecord.
Yusuke Suzuki
Comment 2 2017-09-17 08:23:45 PDT
Created attachment 321044 [details] Patch
Yusuke Suzuki
Comment 3 2017-09-17 10:28:20 PDT
Committed r222136: <http://trac.webkit.org/changeset/222136>
Radar WebKit Bug Importer
Comment 4 2017-09-27 12:59:15 PDT
<rdar://problem/34694427>
Note You need to log in before you can comment on or make changes to this bug.