Bug 17548

Summary: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch
none
Revised proposed patch eric: review+

Brent Fulgham
Reported 2008-02-25 23:29:22 PST
Spidermonkey allows comma-separated arguments to print. These values are printed with a space inbetween. This: print ("foo", "bar") Produces: foo bar In JavaScriptCore it produces: foo
Attachments
Proposed patch (1.36 KB, patch)
2008-06-07 14:04 PDT, Cameron Zwarich (cpst) 		no flags
DetailsFormatted DiffDiff
Revised proposed patch (1.20 KB, patch)
2008-06-07 14:51 PDT, Cameron Zwarich (cpst) 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-06-07 14:04:35 PDT
Created attachment 21565 [details] Proposed patch Here is a patch. It uses indices instead of iterators because our iterators don't have a distance function.
Cameron Zwarich (cpst)
Comment 2 2008-06-07 14:51:27 PDT
Created attachment 21566 [details] Revised proposed patch Includes some changes suggested by Eric.
Eric Seidel (no email)
Comment 3 2008-06-07 14:52:40 PDT
Comment on attachment 21566 [details] Revised proposed patch Looks great! (I think I even wrote work-around code in some test cases instead of fixing this once.)
Cameron Zwarich (cpst)
Comment 4 2008-06-07 14:58:09 PDT
Landed in r34429.
Note You need to log in before you can comment on or make changes to this bug.