Bug 175476

Summary: [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebCore Misc.Assignee: Adrian Perez <aperez>
Severity: Normal CC: cgarcia, commit-queue, darin, ggaren, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Adrian Perez 2017-08-11 05:18:01 PDT
The following warning is generated when building with Clang:

  In file included from ../../Source/WebCore/platform/graphics/ImageBufferData.h:31:
  ../../Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h:65:45: warning: 'proxy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      RefPtr<TextureMapperPlatformLayerProxy> proxy() const;
  ../../Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h:36:53: note: overridden virtual function is here
      virtual RefPtr<TextureMapperPlatformLayerProxy> proxy() const = 0;
Comment 1 Adrian Perez 2017-08-11 05:20:27 PDT
Created attachment 317925 [details]
Comment 2 WebKit Commit Bot 2017-08-11 06:47:03 PDT
Comment on attachment 317925 [details]

Clearing flags on attachment: 317925

Committed r220586: <http://trac.webkit.org/changeset/220586>
Comment 3 WebKit Commit Bot 2017-08-11 06:47:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-11 06:47:48 PDT