Bug 175476 - [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
Summary: [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDat...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
Depends on:
Reported: 2017-08-11 05:18 PDT by Adrian Perez
Modified: 2017-08-11 06:47 PDT (History)
6 users (show)

See Also:

Patch (1.41 KB, patch)
2017-08-11 05:20 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-08-11 05:18:01 PDT
The following warning is generated when building with Clang:

  In file included from ../../Source/WebCore/platform/graphics/ImageBufferData.h:31:
  ../../Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h:65:45: warning: 'proxy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      RefPtr<TextureMapperPlatformLayerProxy> proxy() const;
  ../../Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h:36:53: note: overridden virtual function is here
      virtual RefPtr<TextureMapperPlatformLayerProxy> proxy() const = 0;
Comment 1 Adrian Perez 2017-08-11 05:20:27 PDT
Created attachment 317925 [details]
Comment 2 WebKit Commit Bot 2017-08-11 06:47:03 PDT
Comment on attachment 317925 [details]

Clearing flags on attachment: 317925

Committed r220586: <http://trac.webkit.org/changeset/220586>
Comment 3 WebKit Commit Bot 2017-08-11 06:47:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-11 06:47:48 PDT