| Summary: | [CMake] Many warnings about missing “override” keywords in ANGLE with Clang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, cgarcia, commit-queue, lforschler, mcatanzaro, mmaxfield, thorton, webkit-bug-importer | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 317923 [details]
Patch
Comment on attachment 317923 [details] Patch Clearing flags on attachment: 317923 Committed r220591: <http://trac.webkit.org/changeset/220591> All reviewed patches have been landed. Closing bug. |
Currently building ANGLE as part of WebCore with Clang spews a good bunch of warnings similar to the following one: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.cpp:10: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.h:13: ../../Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.h:86:10: warning: 'visitBranch' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] bool visitBranch(Visit visit, TIntermBranch *); ^ ../../Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h:957:18: note: overridden virtual function is here virtual bool visitBranch(Visit visit, TIntermBranch *node) { return true; } ^ As ANGLE is third-party code, let's to pass “-Wno-inconsistent-missing-override” when building its sources.