Bug 175475 – [CMake] Many warnings about missing “override” keywords in ANGLE with Clang

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

Currently building ANGLE as part of WebCore with Clang spews a good bunch
of warnings similar to the following one:

  In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.cpp:10:
  In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.h:13:
  ../../Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.h:86:10: warning: 'visitBranch' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      bool visitBranch(Visit visit, TIntermBranch *);
           ^
  ../../Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h:957:18: note: overridden virtual function is here
      virtual bool visitBranch(Visit visit, TIntermBranch *node) { return true; }
                   ^

As ANGLE is third-party code, let's to pass “-Wno-inconsistent-missing-override”
when building its sources.

[Adrian Perez]

Created attachment 317923 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 317923 [details]
Patch

Clearing flags on attachment: 317923

Committed r220591: <http://trac.webkit.org/changeset/220591>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.