Bug 175452

Summary: Web Inspector: Ensure three.js gets minified properly
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 174176    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Ross Kirsling
Reported 2017-08-10 15:25:11 PDT
After three.js source is added to Source/WebInspectorUI/UserInterface/External, we must make sure these files are properly minified for release builds.
Attachments
Patch (4.00 KB, patch)
2017-08-14 15:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.24 MB, application/zip)
2017-08-14 20:34 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2017-08-14 15:00:19 PDT
Created attachment 318064 [details] Patch
Ross Kirsling
Comment 2 2017-08-14 15:05:49 PDT
Comment on attachment 318064 [details] Patch Misspoke in my previous comment: Release != production; this is for production builds only. The three.js files haven't yet been added to Main.html, so this currently just spits out the license, but I confirmed that behavior is as expected when Main.html is updated (using copy-user-interface-resources-dryrun.rb).
Build Bot
Comment 3 2017-08-14 20:34:37 PDT
Comment on attachment 318064 [details] Patch Attachment 318064 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4315472 New failing tests: imported/w3c/web-platform-tests/custom-elements/microtasks-and-constructors.html
Build Bot
Comment 4 2017-08-14 20:34:39 PDT
Created attachment 318106 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Ross Kirsling
Comment 5 2017-08-15 10:16:31 PDT
Hopefully it goes without saying that this patch has nothing to do with ios-sim layout tests. That issue is already reported here: https://bugs.webkit.org/show_bug.cgi?id=172732
Blaze Burg
Comment 6 2017-08-17 12:59:45 PDT
Comment on attachment 318064 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-08-17 13:30:16 PDT
Comment on attachment 318064 [details] Patch Clearing flags on attachment: 318064 Committed r220873: <http://trac.webkit.org/changeset/220873>
WebKit Commit Bot
Comment 8 2017-08-17 13:30:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-17 13:31:36 PDT
<rdar://problem/33948519>
Joseph Pecoraro
Comment 10 2017-08-17 13:48:35 PDT
Comment on attachment 318064 [details] Patch On lines 308 and 309 we exclude ESLint.js until it is needed. Should we do the same here or are we going to imminently use it?
Ross Kirsling
Comment 11 2017-08-17 13:54:24 PDT
Good question. I could open a new ticket right now to land the current WIP Patch in https://bugs.webkit.org/show_bug.cgi?id=174176 as a stage-one commit for the Layers tab, if this sounds acceptable to you guys? But if we're not ready for that, then we should temporarily add an exclusion.
Note You need to log in before you can comment on or make changes to this bug.