Bug 175419
| Summary: | [GTK] Several service-workers related tests are failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, csaavedra, dpino, fred.wang, mcatanzaro, youennf, zan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=190196 https://bugs.webkit.org/show_bug.cgi?id=190198 https://bugs.webkit.org/show_bug.cgi?id=201981 |
||
| Bug Depends on: | 178576 | ||
| Bug Blocks: | |||
Miguel Gomez
Service-workers implementation is not complete yet. Some tests are skipped at the general TestExpectations, but those related to cache-storage are already unskipped for mac. These are:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https.html [ Failure ]
These tests were added in r220311. I'm skipping that directory in the gtk TestExpectations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Miguel Gomez
And more service-worker related tests failing, these since r220270 where their expectations were changed:
imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/background-fetch/interfaces.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html [ Failure ]
imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/count-queuing-strategy.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/flow-control.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/multiple-propagation.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/pipe-through.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/transform-streams.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/cancel.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/default-reader.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/general.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/templated.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-byte-streams/general.serviceworker.https.html [ Failure ]
Frédéric Wang (:fredw)
The failing tests are now:
http/tests/workers/service/controller-change.html
http/tests/workers/service/no-page-cache-when-controlled.html
http/wpt/service-workers/persistent-importScripts.html
imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/registration-script.https.html [
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.https.html
It seems most of them are related to an assertion failure:
ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file: /tmp/WebKitTestRunners-maRQFU/ResourceLoadStatistics/full_browsing_session_resourceLog.plist
../../Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp(311) : void WebKit::ResourceLoadStatisticsPersistentStorage::clear()
ASSERTION FAILED: m_ptr
Michael Catanzaro
We should really take the time to implement resource load statistics.
Miguel Gomez
imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html [ Crash ]
imported/w3c/web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https.html [ Crash ]
Michael Catanzaro
One more that was missed:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html [ Failure ]
Michael Catanzaro
Also:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https.html [ Failure ]
Claudio Saavedra
(In reply to Frédéric Wang (:fredw) from comment #2)
> It seems most of them are related to an assertion failure:
> ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics
> file:
> /tmp/WebKitTestRunners-maRQFU/ResourceLoadStatistics/
> full_browsing_session_resourceLog.plist
> ../../Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.
> cpp(311) : void WebKit::ResourceLoadStatisticsPersistentStorage::clear()
I filed https://bugs.webkit.org/show_bug.cgi?id=191152 about this error.
Miguel Gomez
imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html
is now flaky failure/pass. Updating expectations.
Miguel Gomez
http/tests/workers/service/serviceworker-private-browsing.https.html [ Timeout Pass ]
Diego Pino
Two tests are flaky since r251067:
* http/wpt/service-workers/persistent-importScripts.html [ Failure Pass Timeout ]
* http/tests/workers/service/postmessage-after-terminate.https.html [ Failure Pass Timeout ]
I'll update test expectations.
Diego Pino
The following test is timing out since r251067:
* http/wpt/service-workers/service-worker-networkprocess-crash.html
Diego Pino
imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html is passing since r255138. Updated TestExpectations.
Diego Pino
The following test is flaky since [r256865-r256897]:
* http/wpt/service-workers/service-worker-networkprocess-crash.html [ Pass Failure ]