Bug 175409

Summary: Web Inspector: Clicking on suggestion hint should apply it, not dismiss
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
nvasilyev: review-, nvasilyev: commit-queue-
Patch
none
[Animated GIF] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2017-08-09 16:44:47 PDT
Created attachment 317757 [details] [Animated GIF] Bug In Console prompt and Styles sidebar, clicking on the suggestion hint (the gray text), discards the suggestion hint. It should instead apply the suggestion hint.
Attachments
[Animated GIF] Bug (22.28 KB, image/gif)
2017-08-09 16:44 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.84 KB, patch)
2017-08-09 16:49 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2017-08-09 16:57 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (40.95 KB, image/gif)
2017-08-09 16:59 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.88 KB, patch)
2017-08-11 14:44 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-08-09 16:49:21 PDT
Created attachment 317758 [details] Patch
Nikita Vasilyev
Comment 2 2017-08-09 16:53:42 PDT
Comment on attachment 317758 [details] Patch This doesn't in Styles.
Nikita Vasilyev
Comment 3 2017-08-09 16:57:02 PDT
Created attachment 317760 [details] Patch
Nikita Vasilyev
Comment 4 2017-08-09 16:59:11 PDT
Created attachment 317762 [details] [Animated GIF] With patch applied (In reply to Nikita Vasilyev from comment #2) > Comment on attachment 317758 [details] > Patch > > This doesn't in Styles. This doesn't WORK in Styles.
Nikita Vasilyev
Comment 5 2017-08-09 17:15:58 PDT
To clarify, the last patch works in both console and styles.
Matt Baker
Comment 6 2017-08-11 13:47:46 PDT
Comment on attachment 317760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317760&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259 > + setTimeout(() => { this._codeMirror.focus() }, 1); Is there a reason the delay isn't zero?
Nikita Vasilyev
Comment 7 2017-08-11 14:22:12 PDT
(In reply to Matt Baker from comment #6) > Comment on attachment 317760 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317760&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259 > > + setTimeout(() => { this._codeMirror.focus() }, 1); > > Is there a reason the delay isn't zero? No reason. I see we usually use 0, I'll change it for consistency.
Nikita Vasilyev
Comment 8 2017-08-11 14:44:23 PDT
Created attachment 317966 [details] Patch
Matt Baker
Comment 9 2017-08-11 14:51:24 PDT
Comment on attachment 317966 [details] Patch r=me
WebKit Commit Bot
Comment 10 2017-08-11 15:33:31 PDT
Comment on attachment 317966 [details] Patch Clearing flags on attachment: 317966 Committed r220614: <http://trac.webkit.org/changeset/220614>
WebKit Commit Bot
Comment 11 2017-08-11 15:33:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-08-11 15:34:12 PDT
<rdar://problem/33857544>
Note You need to log in before you can comment on or make changes to this bug.