Bug 175394

Summary: [Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2017-08-09 13:10:58 PDT
[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
Attachments
Patch (12.56 KB, patch)
2017-08-09 13:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.54 KB, patch)
2017-08-09 14:13 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-08-09 13:17:12 PDT
Created attachment 317731 [details] Patch
Build Bot
Comment 2 2017-08-09 13:19:33 PDT
Attachment 317731 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/DOMPromiseProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2017-08-09 14:13:05 PDT
Created attachment 317739 [details] Patch
Build Bot
Comment 4 2017-08-09 14:15:59 PDT
Attachment 317739 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/DOMPromiseProxy.h:87: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2017-08-11 17:32:06 PDT
Comment on attachment 317739 [details] Patch Clearing flags on attachment: 317739 Committed r220620: <http://trac.webkit.org/changeset/220620>
WebKit Commit Bot
Comment 6 2017-08-11 17:32:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-11 17:32:39 PDT
<rdar://problem/33859548>
Note You need to log in before you can comment on or make changes to this bug.