Bug 175334

Summary:

REGRESSION: 2 test262/test/language/statements/async-function failures

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

JavaScriptCore

Assignee:

GSkachkov <gskachkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, gskachkov, jlewis3, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=175210

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2017-08-08 11:34:45 PDT

test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default: ERROR: Unexpected exit code: 3
test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default-strict: ERROR: Unexpected exit code: 3
FAIL: test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default-strict
FAIL: test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20Test262%20%28Tests%29/builds/3197

Comment 1 Ryan Haddad 2017-08-08 11:49:42 PDT

These failures started after https://trac.webkit.org/r220323 landed.

Comment 2 GSkachkov 2017-08-08 12:10:31 PDT

Ohh, I did not expect that async function check that there is no async generator
I'll provide patch

Comment 3 Yusuke Suzuki 2017-08-08 12:12:38 PDT

(In reply to GSkachkov from comment #2)
> Ohh, I did not expect that async function check that there is no async
> generator
> I'll provide patch

I think it's safe to make useAsyncIterator false until you finish async iterator work.
In that case, you can specify @skip for async iterator JSTests for now.

After your work is finished, you can set/remove useAsyncIterator flag. And you can specify :failDueToOutdatedOrBadTest in test262.yaml.

Comment 4 GSkachkov 2017-08-09 00:36:01 PDT

Created attachment 317688 [details]
Patch

Patch

Comment 5 Yusuke Suzuki 2017-08-09 00:45:19 PDT

Comment on attachment 317688 [details]
Patch

r=me

Comment 6 WebKit Commit Bot 2017-08-09 02:17:48 PDT

Comment on attachment 317688 [details]
Patch

Clearing flags on attachment: 317688

Committed r220449: <http://trac.webkit.org/changeset/220449>

Comment 7 WebKit Commit Bot 2017-08-09 02:17:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2017-08-09 02:19:11 PDT

<rdar://problem/33795638>