Bug 175301

Summary: Avoid a hash lookup in FilterInfo::remove()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, sam, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Simon Fraser (smfr)
Reported 2017-08-07 16:22:35 PDT
Avoid a hash lookup in FilterInfo::remove()
Attachments
Patch (1.98 KB, patch)
2017-08-07 16:23 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-08-07 16:23:30 PDT
Created attachment 317493 [details] Patch
Sam Weinig
Comment 2 2017-08-07 16:39:45 PDT
Comment on attachment 317493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317493&action=review > Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75 > if (map().remove(&layer)) > layer.m_hasFilterInfo = false; Do you need to check the return value still? Seems like it will always return true now.
Simon Fraser (smfr)
Comment 3 2017-08-07 19:54:03 PDT
https://trac.webkit.org/r220380
Radar WebKit Bug Importer
Comment 4 2017-08-07 19:54:51 PDT
<rdar://problem/33768183>
Note You need to log in before you can comment on or make changes to this bug.