Bug 175301

Summary:

Avoid a hash lookup in FilterInfo::remove()

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, sam, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Simon Fraser (smfr) 2017-08-07 16:22:35 PDT

Avoid a hash lookup in FilterInfo::remove()

Comment 1 Simon Fraser (smfr) 2017-08-07 16:23:30 PDT

Created attachment 317493 [details]
Patch

Comment 2 Sam Weinig 2017-08-07 16:39:45 PDT

Comment on attachment 317493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317493&action=review

> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75
>      if (map().remove(&layer))
>          layer.m_hasFilterInfo = false;

Do you need to check the return value still? Seems like it will always return true now.

Comment 3 Simon Fraser (smfr) 2017-08-07 19:54:03 PDT

https://trac.webkit.org/r220380

Comment 4 Radar WebKit Bug Importer 2017-08-07 19:54:51 PDT

<rdar://problem/33768183>