Bug 175297

Summary: Make TransformOperation::type() non-virtual
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dino, sam, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2017-08-07 15:29:40 PDT
Make TransformOperation::type() non-virtual
Attachments
Patch (27.24 KB, patch)
2017-08-07 15:30 PDT, Simon Fraser (smfr) 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.32 MB, application/zip)
2017-08-07 17:35 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-08-07 15:30:20 PDT
Created attachment 317483 [details] Patch
Build Bot
Comment 2 2017-08-07 15:45:21 PDT
Attachment 317483 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2017-08-07 17:35:54 PDT
Comment on attachment 317483 [details] Patch Attachment 317483 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4273038 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbcursor-key.htm
Build Bot
Comment 4 2017-08-07 17:35:55 PDT
Created attachment 317523 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Simon Fraser (smfr)
Comment 5 2017-08-07 19:53:53 PDT
https://trac.webkit.org/r220379
Radar WebKit Bug Importer
Comment 6 2017-08-07 19:54:46 PDT
<rdar://problem/33768182>
Note You need to log in before you can comment on or make changes to this bug.