Bug 175286

Summary: check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, don.olmstead, glenn, lforschler, mmaxfield, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoshiaki Jitsukawa
Reported 2017-08-07 14:23:06 PDT
For example, the following code in Source/WebCore/platform/spi/cocoa/PassKitSPI.h causes a "Place brace on its own line for function definitions. [whitespace/braces] [4]" error typedef NS_ERROR_ENUM(PKPaymentErrorDomain, PKPaymentErrorCode) { PKPaymentUnknownError = -1, ...
Attachments
Patch (3.73 KB, patch)
2017-08-07 14:39 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-08-07 14:30:36 PDT
Moving platform/spi/cocoa/ into PAL will raise these kind of style errors so I'm fixing this in advance.
Yoshiaki Jitsukawa
Comment 2 2017-08-07 14:39:33 PDT
Created attachment 317469 [details] Patch
Yoshiaki Jitsukawa
Comment 3 2017-08-07 15:17:24 PDT
Thank you for your reviewing!
WebKit Commit Bot
Comment 4 2017-08-07 16:25:31 PDT
Comment on attachment 317469 [details] Patch Clearing flags on attachment: 317469 Committed r220367: <http://trac.webkit.org/changeset/220367>
WebKit Commit Bot
Comment 5 2017-08-07 16:25:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-07 16:26:12 PDT
<rdar://problem/33764837>
Note You need to log in before you can comment on or make changes to this bug.