Bug 175252

Summary:

Analysis task page shows an empty results for an irrelevant top-level test

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dewei_zhu, kling, koivisto, rniwa, saam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none
Rebased for trunk	none

Ryosuke Niwa

Reported 2017-08-06 17:10:31 PDT

When there are multiple tests being tested in a single analysis task for perf try bots, the test group results reviewer lists every test ever listed in the analysis task for every test group.

Attachments
Fixes the bug (4.45 KB, patch) 2017-08-06 17:17 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Rebased for trunk (4.28 KB, patch) 2017-09-10 18:08 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-08-06 17:17:57 PDT

Created attachment 317388 [details] Fixes the bug

Ryosuke Niwa

Comment 2 2017-09-10 18:08:21 PDT

Created attachment 320410 [details] Rebased for trunk

Ryosuke Niwa

Comment 3 2017-09-10 18:11:24 PDT

This patch fixes the bug that analysis task pages for perf try bots show enumerate the union of all top level tests tested instead of the one tested in a particular test group. e.g. if you tested Speedometer & JetStream on a single perf try bots page, then both test groups enumerate both Speedometer & JetStream despite of the fact each test group tested exactly one of them.

Antti Koivisto

Comment 4 2017-09-11 05:15:20 PDT

Comment on attachment 320410 [details] Rebased for trunk r=me

Ryosuke Niwa

Comment 5 2017-09-11 11:56:35 PDT

Comment on attachment 320410 [details] Rebased for trunk Thanks for the review.

WebKit Commit Bot

Comment 6 2017-09-11 12:26:03 PDT

Comment on attachment 320410 [details] Rebased for trunk Clearing flags on attachment: 320410 Committed r221871: <http://trac.webkit.org/changeset/221871>

WebKit Commit Bot

Comment 7 2017-09-11 12:26:05 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2017-09-27 12:49:54 PDT

<rdar://problem/34694096>

Note You need to log in before you can comment on or make changes to this bug.