Bug 175252

Summary: Analysis task page shows an empty results for an irrelevant top-level test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dewei_zhu, kling, koivisto, rniwa, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Rebased for trunk none

Description Ryosuke Niwa 2017-08-06 17:10:31 PDT 
When there are multiple tests being tested in a single analysis task for perf try bots,
the test group results reviewer lists every test ever listed in the analysis task for every test group.
Comment 1 Ryosuke Niwa 2017-08-06 17:17:57 PDT 
Created attachment 317388 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2017-09-10 18:08:21 PDT 
Created attachment 320410 [details]
Rebased for trunk
Comment 3 Ryosuke Niwa 2017-09-10 18:11:24 PDT 
This patch fixes the bug that analysis task pages for perf try bots show enumerate the union of all top level tests tested instead of the one tested in a particular test group. e.g. if you tested Speedometer & JetStream on a single perf try bots page, then both test groups enumerate both Speedometer & JetStream despite of the fact each test group tested exactly one of them.
Comment 4 Antti Koivisto 2017-09-11 05:15:20 PDT 
Comment on attachment 320410 [details]
Rebased for trunk

r=me
Comment 5 Ryosuke Niwa 2017-09-11 11:56:35 PDT 
Comment on attachment 320410 [details]
Rebased for trunk

Thanks for the review.
Comment 6 WebKit Commit Bot 2017-09-11 12:26:03 PDT 
Comment on attachment 320410 [details]
Rebased for trunk

Clearing flags on attachment: 320410

Committed r221871: <http://trac.webkit.org/changeset/221871>
Comment 7 WebKit Commit Bot 2017-09-11 12:26:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:49:54 PDT 
<rdar://problem/34694096>