Summary: | Add ServiceWorkerJob | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||
Status: | ASSIGNED --- | ||||||||||||||
Severity: | Normal | CC: | aestes, buildbot, cdumez, commit-queue, jrburke, olivier, thorton | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=174541 | ||||||||||||||
Attachments: |
|
Description
Brady Eidson
2017-08-05 21:22:17 PDT
To keep the patch small, I'll just be adding ServiceWorkerJob and using it for one immediate promise rejection. We'll queue jobs in the next patch. Created attachment 317761 [details]
Patch
Created attachment 317778 [details]
Patch
Comment on attachment 317778 [details] Patch Attachment 317778 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4287820 New failing tests: fast/dom/insertedIntoDocument-sibling.html Created attachment 317783 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
(In reply to Build Bot from comment #5) > Created attachment 317783 [details] > Archive of layout-test-results from ews125 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5 The crashing test is definitely not the result of this patch. Comment on attachment 317778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317778&action=review > Source/WebCore/workers/ServiceWorkerJob.cpp:48 > +#ifndef NDEBUG You shouldn't need these. > Source/WebCore/workers/ServiceWorkerJob.cpp:55 > +#ifndef NDEBUG You shouldn't need these. > Source/WebCore/workers/ServiceWorkerJob.h:64 > +#ifndef NDEBUG ASSERT_DISABLED Created attachment 317822 [details]
Landing run
Created attachment 317823 [details]
Landing run
Comment on attachment 317823 [details] Landing run Clearing flags on attachment: 317823 Committed r220539: <http://trac.webkit.org/changeset/220539> |