Bug 175205

Summary: [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKitGTKAssignee: Blaze Burg <bburg>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bburg, bugs-noreply, cgarcia, joepeck, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175207    
Attachments:
Description Flags
Patch cgarcia: review+

Blaze Burg
Reported 2017-08-04 13:35:41 PDT
This was introduced to CMake here, turned off by default: https://trac.webkit.org/changeset/170964/webkit It's enabled everywhere else. Let's turn it on so I can remove another pointless compile flag.
Attachments
Patch (1.36 KB, patch)
2017-08-04 13:37 PDT, Blaze Burg 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-08-04 13:37:35 PDT
Created attachment 317276 [details] Patch
Carlos Garcia Campos
Comment 2 2017-08-05 00:23:32 PDT
Comment on attachment 317276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317276&action=review > Source/cmake/OptionsGTK.cmake:155 > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF) > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE ON) I have no idea why we have OFF here. Since the default is ON, we can probably remove the line, but you are going to remove the build gflag eventually, so it doesn't really matter. > ChangeLog:3 > + [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default This doesn't change WPE
Michael Catanzaro
Comment 3 2017-08-05 12:23:39 PDT
Yes, just remove it from OptionsGTK.cmake.
Blaze Burg
Comment 4 2017-08-07 08:59:18 PDT
(In reply to Michael Catanzaro from comment #3) > Yes, just remove it from OptionsGTK.cmake. Ok, I'll just mark this patch invalid and land 175207 (removes the guard entirely)
Blaze Burg
Comment 5 2017-08-07 08:59:31 PDT
*** This bug has been marked as a duplicate of bug 175207 ***
Note You need to log in before you can comment on or make changes to this bug.