Bug 175194

Summary:

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, dmazzoni, jcraig, jdiggs, jlewis3, n_wang, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=173930

Attachments:

Description	Flags
patch	cfleizach: review+

Description Ryan Haddad 2017-08-04 10:04:52 PDT

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r220267%20(2810)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fpresentation-role-iframe.html

Comment 1 Ryan Haddad 2017-08-04 10:06:14 PDT

This test was added with https://trac.webkit.org/changeset/219075/webkit

Comment 2 Ryan Haddad 2017-08-04 10:07:36 PDT

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-actual.txt
@@ -8,10 +8,10 @@
 
 1. Content child: AXRole: AXGroup
 1. Content grand child: AXRole: AXButton
+3. Content child: AXRole: AXGroup
+3. Content grand child: AXRole: AXButton
 2. Content child: AXRole: AXScrollArea
 2. Content grand child: AXRole: AXWebArea
-3. Content child: AXRole: AXGroup
-3. Content grand child: AXRole: AXButton
 PASS successfullyParsed is true
 
 TEST COMPLETE

Comment 3 Ryan Haddad 2017-08-04 10:08:00 PDT

Chris, it looks like this test has been flaky since it was added. Could you take a look?

Comment 4 chris fleizach 2017-08-04 18:05:43 PDT

(In reply to Ryan Haddad from comment #3)
> Chris, it looks like this test has been flaky since it was added. Could you
> take a look?

Yep, will do.

Comment 5 Nan Wang 2017-08-09 13:52:48 PDT

Created attachment 317735 [details]
patch

Comment 6 chris fleizach 2017-08-09 15:24:26 PDT

Comment on attachment 317735 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317735&action=review

r+ with style change

> LayoutTests/accessibility/presentation-role-iframe.html:33
> +var test1Log, test2Log, test3Log

semi-colon at the end?
also I think WebKit likes to put each variable on a separate line.

> LayoutTests/accessibility/presentation-role-iframe.html:62
> +    var result =  testNumber + ". Content child: " + content.childAtIndex(0).role;

extra space after =

Comment 7 Nan Wang 2017-08-09 15:36:06 PDT

Committed r220486: <http://trac.webkit.org/changeset/220486>

Comment 8 Radar WebKit Bug Importer 2017-08-09 15:37:32 PDT

<rdar://problem/33813333>