Bug 175183 – WebDriver: Implement page load strategy

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

https://w3c.github.io/webdriver/webdriver-spec.html#navigation

[Carlos Garcia Campos]

Created attachment 317239 [details]
Patch

[Blaze Burg]

Comment on attachment 317239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317239&action=review

r=me, great work. Please send through EWS before landing.

> Source/WebKit/ChangeLog:8
> +        Split pending navigation maps into normal and eager, and one or the other depending on the received page load strategy.

Nit: ... and *use* one or the other ...

You don't actually say why two maps are needed here.

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:459
> +static void finishPendingNavigationsWithTimeoutFailure(HashMap<uint64_t, RefPtr<Inspector::BackendDispatcher::CallbackBase>>& map)

Nit: I prefer a name like "respondToPendingNavigationCallbacksWithTimeout" or something.

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:519
> +    Inspector::Protocol::Automation::PageLoadStrategy pageLoadStrategy = defaultPageLoadStrategy;

Okay, we have this same code three times. Can you extract it?

[Carlos Garcia Campos]

Created attachment 317334 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r220317: <http://trac.webkit.org/changeset/220317>

[Radar WebKit Bug Importer]

<rdar://problem/33740067>