Bug 175182

Summary: check-webkit-style: fix path-specific rules for WebKit2 rename
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ddkilzer, glenn, jbedard, lforschler, matthew_hanson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoshiaki Jitsukawa
Reported 2017-08-04 03:41:00 PDT
The path-specific rules should be fixed for the WebKit2 -> WebKit renaming.
Attachments
Patch (3.92 KB, patch)
2017-08-04 03:48 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-08-04 03:48:02 PDT
Created attachment 317232 [details] Patch
Yoshiaki Jitsukawa
Comment 2 2017-08-04 15:18:20 PDT
(Let me CC ddkilzer from the commit log.) Hello, David. I found some "WebKit2" remain in the style checker script. Would you please review my patch to fix them?
David Kilzer (:ddkilzer)
Comment 3 2017-08-05 16:18:10 PDT
Comment on attachment 317232 [details] Patch Nice find! r=me
Yoshiaki Jitsukawa
Comment 4 2017-08-05 16:44:18 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 317232 [details] > Patch > > Nice find! r=me Thank you for your reviewing!
WebKit Commit Bot
Comment 5 2017-08-05 16:48:29 PDT
Comment on attachment 317232 [details] Patch Clearing flags on attachment: 317232 Committed r220321: <http://trac.webkit.org/changeset/220321>
WebKit Commit Bot
Comment 6 2017-08-05 16:48:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-05 16:49:14 PDT
<rdar://problem/33742368>
Matthew Hanson
Comment 8 2017-08-07 11:12:34 PDT
Thank you for finding/fixing this, Yoshiaki!
Yoshiaki Jitsukawa
Comment 9 2017-08-07 14:22:16 PDT
(In reply to Matthew Hanson from comment #8) > Thank you for finding/fixing this, Yoshiaki! Not at all, Matthew!
Note You need to log in before you can comment on or make changes to this bug.