Bug 175182 - check-webkit-style: fix path-specific rules for WebKit2 rename
Summary: check-webkit-style: fix path-specific rules for WebKit2 rename
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-04 03:41 PDT by Yoshiaki Jitsukawa
Modified: 2017-08-07 14:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2017-08-04 03:48 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-08-04 03:41:00 PDT 
The path-specific rules should be fixed for the WebKit2 -> WebKit renaming.
Comment 1 Yoshiaki Jitsukawa 2017-08-04 03:48:02 PDT 
Created attachment 317232 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2017-08-04 15:18:20 PDT 
(Let me CC ddkilzer from the commit log.)

Hello, David.
I found some "WebKit2" remain in the style checker script. Would you please review my patch to fix them?
Comment 3 David Kilzer (:ddkilzer) 2017-08-05 16:18:10 PDT 
Comment on attachment 317232 [details]
Patch

Nice find!  r=me
Comment 4 Yoshiaki Jitsukawa 2017-08-05 16:44:18 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 317232 [details]
> Patch
> 
> Nice find!  r=me

Thank you for your reviewing!
Comment 5 WebKit Commit Bot 2017-08-05 16:48:29 PDT 
Comment on attachment 317232 [details]
Patch

Clearing flags on attachment: 317232

Committed r220321: <http://trac.webkit.org/changeset/220321>
Comment 6 WebKit Commit Bot 2017-08-05 16:48:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-05 16:49:14 PDT 
<rdar://problem/33742368>
Comment 8 Matthew Hanson 2017-08-07 11:12:34 PDT 
Thank you for finding/fixing this, Yoshiaki!
Comment 9 Yoshiaki Jitsukawa 2017-08-07 14:22:16 PDT 
(In reply to Matthew Hanson from comment #8)
> Thank you for finding/fixing this, Yoshiaki!

Not at all, Matthew!