Bug 175178

Summary: EventSource: ignore IDs with U+0000
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/whatwg/html/pull/2849
Bug Depends on: 175556    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch none

Description Anne van Kesteren 2017-08-04 01:02:05 PDT 
Change to standard: https://github.com/whatwg/html/pull/2849

Proposed tests (still need review): https://github.com/w3c/web-platform-tests/pull/6584

It seems good to fix this as this is the only way for someone to smuggle a U+0000 into a header value.
Comment 1 Chris Dumez 2017-08-14 16:34:12 PDT 
Created attachment 318082 [details]
WIP Patch
Comment 2 Chris Dumez 2017-08-15 09:36:08 PDT 
Created attachment 318125 [details]
WIP Patch

WPT fails for some reason. I am not sure why so I asked for clarification upstream.
Comment 3 Chris Dumez 2017-08-16 09:12:03 PDT 
Created attachment 318264 [details]
Patch
Comment 4 WebKit Commit Bot 2017-08-16 10:30:42 PDT 
Comment on attachment 318264 [details]
Patch

Clearing flags on attachment: 318264

Committed r220799: <http://trac.webkit.org/changeset/220799>
Comment 5 WebKit Commit Bot 2017-08-16 10:30:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-16 10:31:50 PDT 
<rdar://problem/33921417>