Bug 175175

Summary: [PAL] Move spi/cocoa and spi/cg directories into PAL
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, don.olmstead, koivisto, mmaxfield, sam, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
mmaxfield: review+
Patch none

Description Yoshiaki Jitsukawa 2017-08-03 22:11:34 PDT 
Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL

This is to move platform/spi/cocoa to PAL.
Comment 1 Yoshiaki Jitsukawa 2017-08-07 17:50:25 PDT 
Created attachment 317527 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2017-08-08 03:26:01 PDT 
Created attachment 317556 [details]
Patch
Comment 3 Yoshiaki Jitsukawa 2017-08-08 03:50:37 PDT 
There's interdependency between spi/cocoa and spi/cg so these two need to be moved at once.
Comment 4 Yoshiaki Jitsukawa 2017-08-08 14:15:57 PDT 
Created attachment 317610 [details]
Patch
Comment 5 Yoshiaki Jitsukawa 2017-08-08 16:07:36 PDT 
Created attachment 317637 [details]
Patch
Comment 6 Yoshiaki Jitsukawa 2017-08-08 16:25:46 PDT 
Created attachment 317640 [details]
Patch
Comment 7 Myles C. Maxfield 2017-08-09 17:15:41 PDT 
Comment on attachment 317640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317640&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames shouldn't require an OWNER. Other than the style for the "*" character, this looks good.

> Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.hSource/WebCore/platform/spi/cocoa/AVKitSPI.h:74
> +@property (nonatomic, readonly) AVPictureInPicturePlayerLayerView* pictureInPicturePlayerLayerView;

Unfortunately, this is actually backwards. The style is:

For C and C++ types:
Type* foo;

For Objective-C types:
Type *foo;
Comment 8 Yoshiaki Jitsukawa 2017-08-09 17:39:22 PDT 
(In reply to Myles C. Maxfield from comment #7)
Thank you! I'll fix the style for Objective-C.
Comment 9 Yoshiaki Jitsukawa 2017-08-09 18:59:29 PDT 
Created attachment 317774 [details]
Patch
Comment 10 WebKit Commit Bot 2017-08-09 21:13:14 PDT 
Comment on attachment 317774 [details]
Patch

Clearing flags on attachment: 317774

Committed r220506: <http://trac.webkit.org/changeset/220506>
Comment 11 WebKit Commit Bot 2017-08-09 21:13:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-08-09 21:14:24 PDT 
<rdar://problem/33820041>