Bug 175171

Summary:

[PAL] Move spi/ios and spi/win directories into PAL

Product:

WebKit

Reporter:

Yoshiaki Jitsukawa <yoshiaki.jitsukawa>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, bdakin, buildbot, commit-queue, don.olmstead, koivisto, mmaxfield, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	koivisto: review+, commit-queue: commit-queue-
Patch	none
Patch	none

Yoshiaki Jitsukawa

Reported 2017-08-03 18:58:03 PDT

Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL This is to move other 13 SPI files in the cg, ios and win directories.

Attachments
Patch (86.71 KB, patch) 2017-08-09 23:11 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (65.05 KB, patch) 2017-08-10 02:54 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (62.28 KB, patch) 2017-08-10 04:02 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (62.28 KB, patch) 2017-08-10 09:11 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (69.62 KB, patch) 2017-08-15 15:32 PDT, Yoshiaki Jitsukawa	koivisto: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (64.65 KB, patch) 2017-08-16 12:35 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Patch (64.65 KB, patch) 2017-08-16 13:16 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Yoshiaki Jitsukawa

Comment 1 2017-08-09 23:11:18 PDT

Created attachment 317785 [details] Patch

Yoshiaki Jitsukawa

Comment 2 2017-08-10 02:54:28 PDT

Created attachment 317798 [details] Patch

Yoshiaki Jitsukawa

Comment 3 2017-08-10 04:02:45 PDT

Created attachment 317800 [details] Patch

Yoshiaki Jitsukawa

Comment 4 2017-08-10 09:11:02 PDT

Created attachment 317813 [details] Patch

Yoshiaki Jitsukawa

Comment 5 2017-08-15 15:32:56 PDT

Created attachment 318184 [details] Patch

Yoshiaki Jitsukawa

Comment 6 2017-08-15 19:07:02 PDT

To WebKit OWNERS: Would you please review my patch? This patch moves files under WebCore/platform/spi/ios,win to PAL/pal/spi/, modifies WebCore/PAL Xcode projects and fixes coding style errors for it.

Antti Koivisto

Comment 7 2017-08-16 02:54:03 PDT

Comment on attachment 318184 [details] Patch Looks reasonable, rs=me

Build Bot

Comment 8 2017-08-16 03:00:26 PDT

Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Yoshiaki.Jitsukawa@sony.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 9 2017-08-16 07:12:28 PDT

Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 318184, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/mac/EventSendingController.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4324366

WebKit Commit Bot

Comment 10 2017-08-16 07:20:37 PDT

Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 318184, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/mac/EventSendingController.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4324392

Yoshiaki Jitsukawa

Comment 11 2017-08-16 12:35:53 PDT

Created attachment 318281 [details] Patch Updating the patch for the latest source tree.

Yoshiaki Jitsukawa

Comment 12 2017-08-16 13:16:16 PDT

Created attachment 318284 [details] Patch

WebKit Commit Bot

Comment 13 2017-08-16 14:42:17 PDT

Comment on attachment 318284 [details] Patch Clearing flags on attachment: 318284 Committed r220809: <http://trac.webkit.org/changeset/220809>

WebKit Commit Bot

Comment 14 2017-08-16 14:42:18 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2017-08-16 14:56:49 PDT

<rdar://problem/33927452>

Note You need to log in before you can comment on or make changes to this bug.