Bug 175157

Summary: Dashboard bubbles sometimes show failure count instead of crash count
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, jlewis3, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=142364
https://bugs.webkit.org/show_bug.cgi?id=175200
Attachments:
Description Flags
Proposed patch
ap: review+
Patch for landing none

Aakash Jain
Reported 2017-08-03 15:00:57 PDT
See <rdar://problem/33709009>
Attachments
Proposed patch (1.76 KB, patch)
2017-08-03 15:05 PDT, Aakash Jain 		ap: review+
DetailsFormatted DiffDiff
Patch for landing (1.76 KB, patch)
2017-08-04 11:55 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-08-03 15:05:41 PDT
Created attachment 317163 [details] Proposed patch
Aakash Jain
Comment 2 2017-08-03 17:41:05 PDT
This change wasn't required earlier, because with buildbot 0.8, testStep.results[1] used to be an array, but in buildbot 0.9, the same is replaced with state_string which is a string (equivalent to concatenated array). Old Sample testStep.results[1]: [ "53 failures", "37 new passes", "1 crashes" ] New sample state_string: "53 failures 37 new passes 1 crashes"
Daniel Bates
Comment 3 2017-08-03 19:11:04 PDT
Can we write a unit test for this change?
Alexey Proskuryakov
Comment 4 2017-08-04 09:35:14 PDT
Comment on attachment 317163 [details] Proposed patch I think it's worth adding a comment explaining which two cases we support here, especially given that there is no regression test.
Aakash Jain
Comment 5 2017-08-04 11:55:04 PDT
Created attachment 317263 [details] Patch for landing Added a comment mentioning sample data. We only support the new format (buildbot 0.8 data is already converted to buildbot 0.9 format before reaching here). Filed https://bugs.webkit.org/show_bug.cgi?id=175200 for adding unit tests.
WebKit Commit Bot
Comment 6 2017-08-04 13:01:19 PDT
Comment on attachment 317263 [details] Patch for landing Clearing flags on attachment: 317263 Committed r220287: <http://trac.webkit.org/changeset/220287>
WebKit Commit Bot
Comment 7 2017-08-04 13:01:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.