| Summary: | Dashboard bubbles sometimes show failure count instead of crash count | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dbates, jlewis3, lforschler, ryanhaddad, webkit-bug-importer | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=142364 https://bugs.webkit.org/show_bug.cgi?id=175200 |
||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2017-08-03 15:00:57 PDT
Created attachment 317163 [details]
Proposed patch
This change wasn't required earlier, because with buildbot 0.8, testStep.results[1] used to be an array, but in buildbot 0.9, the same is replaced with state_string which is a string (equivalent to concatenated array).
Old Sample testStep.results[1]:
[
"53 failures",
"37 new passes",
"1 crashes"
]
New sample state_string:
"53 failures 37 new passes 1 crashes"
Can we write a unit test for this change? Comment on attachment 317163 [details]
Proposed patch
I think it's worth adding a comment explaining which two cases we support here, especially given that there is no regression test.
Created attachment 317263 [details] Patch for landing Added a comment mentioning sample data. We only support the new format (buildbot 0.8 data is already converted to buildbot 0.9 format before reaching here). Filed https://bugs.webkit.org/show_bug.cgi?id=175200 for adding unit tests. Comment on attachment 317263 [details] Patch for landing Clearing flags on attachment: 317263 Committed r220287: <http://trac.webkit.org/changeset/220287> All reviewed patches have been landed. Closing bug. |