ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll uses the wrong fixedPositionRect

• Component: Frames
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

Extracted from bug 154399.

[Frédéric Wang (:fredw)]

Created attachment 317124 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 317124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317124&action=review

> Source/WebCore/ChangeLog:11
> +        and RenderLayerCompositor. This allows to fix some flickering issues on iOS.

allows to fix => fixes

> Source/WebKit/ChangeLog:11
> +        and RenderLayerCompositor. This allows to fix some flickering issues on iOS.

ditto

> Source/WebKit/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:281
> +    if (frameNode && frameNode->parent())
> +        fixedPositionRect = frameNode->fixedPositionRect();
> +    else
> +        fixedPositionRect = scrollingTree().fixedPositionRect();

It's not clear why you check frameNode->parent() here. Is frameNode->fixedPositionRect() on the root frame node not the same as scrollingTree().fixedPositionRect()?

[Build Bot]

Comment on attachment 317124 [details]
Patch

Attachment 317124 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4247126

New failing tests:
http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html

[Build Bot]

Created attachment 317129 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Frédéric Wang (:fredw)]

(In reply to Simon Fraser (smfr) from comment #2)
> > Source/WebKit/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:281
> > +    if (frameNode && frameNode->parent())
> > +        fixedPositionRect = frameNode->fixedPositionRect();
> > +    else
> > +        fixedPositionRect = scrollingTree().fixedPositionRect();
> 
> It's not clear why you check frameNode->parent() here. Is
> frameNode->fixedPositionRect() on the root frame node not the same as
> scrollingTree().fixedPositionRect()?

I'm copying what is done for the ScrollingTreeFrameScrollingNodeIOS:

https://trac.webkit.org/browser/trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm#L171

At the end scrollingTree().fixedPositionRect() involves WebPageProxy::computeCustomFixedPositionRect which seems to do quite complex calculation. The fixedPositionRect() function I introduced here, only does the simple calculation of ScrollingTreeFrameScrollingNodeIOS.

[Frédéric Wang (:fredw)]

(In reply to Build Bot from comment #3)
> Comment on attachment 317124 [details]
> Patch
> 
> Attachment 317124 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/4247126
> 
> New failing tests:
> http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-
> https.html

This failure seems unrelated and the test passes locally for me.

[Frédéric Wang (:fredw)]

Committed r220261: <http://trac.webkit.org/changeset/220261>

[Radar WebKit Bug Importer]

<rdar://problem/33719582>