Bug 175129

Summary: [EME] Push CDMFactory into the platform layer
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175136    
Attachments:
Description Flags
WIP
none
Patch
none
Patch for landing none

Zan Dobersek
Reported 2017-08-03 05:18:46 PDT
[EME] Push CDMFactory into the platform layer
Attachments
WIP (17.61 KB, patch)
2017-08-03 05:21 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (18.00 KB, patch)
2017-08-03 08:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.17 KB, patch)
2017-08-04 02:51 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-08-03 05:21:03 PDT
Created attachment 317115 [details] WIP
Zan Dobersek
Comment 2 2017-08-03 08:29:16 PDT
Created attachment 317122 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2017-08-04 02:07:27 PDT
Comment on attachment 317122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317122&action=review > Source/WebCore/platform/GStreamer.cmake:142 > + platform/encryptedmedia/gstreamer/CDMFactoryGStreamer.cpp It looks like this file should go under platform/graphics/gstreamer/eme/ > Source/WebCore/platform/encryptedmedia/CDMFactory.cpp:2 > + * Copyright (C) 2016 Apple Inc. All rights reserved. It looks like Igalia can have some credit here. > Source/WebCore/platform/encryptedmedia/CDMFactory.h:2 > + * Copyright (C) 2016 Apple Inc. All rights reserved. Ditto > Source/WebCore/platform/encryptedmedia/CDMFactory.h:49 > + // CDMFactory objectes is queried for the first time. typo
Zan Dobersek
Comment 4 2017-08-04 02:51:00 PDT
Created attachment 317230 [details] Patch for landing
Zan Dobersek
Comment 5 2017-08-04 02:54:45 PDT
Comment on attachment 317230 [details] Patch for landing Clearing flags on attachment: 317230 Committed r220264: <http://trac.webkit.org/changeset/220264>
Zan Dobersek
Comment 6 2017-08-04 02:54:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-04 02:56:03 PDT
<rdar://problem/33720760>
Note You need to log in before you can comment on or make changes to this bug.