Bug 175128

Summary: [EME] CDM constructor assigns CDMPrivate member multiple times
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Zan Dobersek
Reported 2017-08-03 05:01:44 PDT
[EME] CDM constructor assigns CDMPrivate member multiple times
Attachments
Patch (2.55 KB, patch)
2017-08-03 05:11 PDT, Zan Dobersek 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-08-03 05:11:02 PDT
Created attachment 317114 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-08-03 07:04:40 PDT
Comment on attachment 317114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317114&action=review > Source/WebCore/ChangeLog:13 > + In the CDM class constructor, create the CDMPrivate object for > + the first key system we're able to determine as being supported, > + stopping iteration of the registered CDM factories at that point. > + This is done in a dedicated loop inside the constructor body, > + meaning the helper createCDMPrivateForKeySystem() function can > + be removed. I find syntax of the first sentence a bit complex to understand.
Zan Dobersek
Comment 3 2017-08-03 07:40:50 PDT
Committed r220203: <http://trac.webkit.org/changeset/220203>
Radar WebKit Bug Importer
Comment 4 2017-08-03 07:43:28 PDT
<rdar://problem/33699787>
Note You need to log in before you can comment on or make changes to this bug.