Bug 175128 - [EME] CDM constructor assigns CDMPrivate member multiple times
Summary: [EME] CDM constructor assigns CDMPrivate member multiple times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-03 05:01 PDT by Zan Dobersek
Modified: 2017-08-03 07:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2017-08-03 05:11 PDT, Zan Dobersek 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-03 05:01:44 PDT 
[EME] CDM constructor assigns CDMPrivate member multiple times
Comment 1 Zan Dobersek 2017-08-03 05:11:02 PDT 
Created attachment 317114 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2017-08-03 07:04:40 PDT 
Comment on attachment 317114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317114&action=review

> Source/WebCore/ChangeLog:13
> +        In the CDM class constructor, create the CDMPrivate object for
> +        the first key system we're able to determine as being supported,
> +        stopping iteration of the registered CDM factories at that point.
> +        This is done in a dedicated loop inside the constructor body,
> +        meaning the helper createCDMPrivateForKeySystem() function can
> +        be removed.

I find syntax of the first sentence a bit complex to understand.
Comment 3 Zan Dobersek 2017-08-03 07:40:50 PDT 
Committed r220203: <http://trac.webkit.org/changeset/220203>
Comment 4 Radar WebKit Bug Importer 2017-08-03 07:43:28 PDT 
<rdar://problem/33699787>