Bug 175110

Summary: Remove LayoutUnit dependency in TextStream
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mmaxfield, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2017-08-02 19:38:12 PDT
A TextStream operator<< implementation for LayoutUnit is currently defined within TextStream directly. The TextStream operator<< for LayoutUnit should be within LayoutUnit's definition. This dependency makes it harder to move TextStream to PAL and should be removed.
Attachments
Patch (7.75 KB, patch)
2017-08-02 20:01 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.79 KB, patch)
2017-08-03 13:20 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (9.42 KB, patch)
2017-08-03 13:52 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-08-02 20:01:36 PDT
Created attachment 317071 [details] Patch
Don Olmstead
Comment 2 2017-08-02 20:25:16 PDT
Comment on attachment 317071 [details] Patch Myles can I get a review? I can fix the xcode project so Mac builds tomorrow. After that I'll see if I can get TextStream into PAL.
Myles C. Maxfield
Comment 3 2017-08-02 22:09:42 PDT
Comment on attachment 317071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review I think this is good but I won’t give it the formal review until the EWS bubbles are green. > Source/WebCore/platform/LayoutUnit.cpp:2 > + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved. The dates and the company seem wrong
Myles C. Maxfield
Comment 4 2017-08-02 22:10:48 PDT
Comment on attachment 317071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review >> Source/WebCore/platform/LayoutUnit.cpp:2 >> + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved. > > The dates and the company seem wrong I guess you’re just moving code, so I guess they’re right.
Don Olmstead
Comment 5 2017-08-03 13:20:03 PDT
Created attachment 317143 [details] Patch Rebased after sorting
Don Olmstead
Comment 6 2017-08-03 13:52:18 PDT
Created attachment 317148 [details] Patch Hopefully fix xcode
WebKit Commit Bot
Comment 7 2017-08-03 19:37:56 PDT
Comment on attachment 317148 [details] Patch Clearing flags on attachment: 317148 Committed r220249: <http://trac.webkit.org/changeset/220249>
WebKit Commit Bot
Comment 8 2017-08-03 19:37:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-03 19:39:00 PDT
<rdar://problem/33715434>
Note You need to log in before you can comment on or make changes to this bug.